Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:07, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break statement and replacing a > comment with a goto statement instead of letting the code fall through > to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > --- > net/sctp/input.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/input.c b/net/sctp/input.c > index d508f6f3dd08..5ceaf75105ba 100644 > --- a/net/sctp/input.c > +++ b/net/sctp/input.c > @@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info) > break; > case ICMP_REDIRECT: > sctp_icmp_redirect(sk, transport, skb); > - /* Fall through to out_unlock. */ > + goto out_unlock; > default: > goto out_unlock; > } > @@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net, > net, ch, laddr, > sctp_hdr(skb)->source, > transportp); > + break; > default: > break; > } >
