Re: [PATCH ipsec] esp: delete NETIF_F_SCTP_CRC bit from features for esp offload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 19, 2021 at 03:35:07PM +0800, Xin Long wrote:
> Now in esp4/6_gso_segment(), before calling inner proto .gso_segment,
> NETIF_F_CSUM_MASK bits are deleted, as HW won't be able to do the
> csum for inner proto due to the packet encrypted already.
> 
> So the UDP/TCP packet has to do the checksum on its own .gso_segment.
> But SCTP is using CRC checksum, and for that NETIF_F_SCTP_CRC should
> be deleted to make SCTP do the csum in own .gso_segment as well.
> 
> In Xiumei's testing with SCTP over IPsec/veth, the packets are kept
> dropping due to the wrong CRC checksum.
> 
> Reported-by: Xiumei Mu <xmu@xxxxxxxxxx>
> Fixes: 7862b4058b9f ("esp: Add gso handlers for esp4 and esp6")
> Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx>

Applied, thanks Xin!



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux