Re: [PATCHv2 net] sctp: get netns from asoc and ep base

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 10, 2019 at 2:14 AM David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Xin Long <lucien.xin@xxxxxxxxx>
> Date: Mon,  9 Dec 2019 13:45:18 +0800
>
> > Commit 312434617cb1 ("sctp: cache netns in sctp_ep_common") set netns
> > in asoc and ep base since they're created, and it will never change.
> > It's a better way to get netns from asoc and ep base, comparing to
> > calling sock_net().
> >
> > This patch is to replace them.
> >
> > v1->v2:
> >   - no change.
> >
> > Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx>
> > Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx>
> > Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
>
> This looks like a cleanup rather than a bug fix, so net-next right?
Yes, a cleanup, and net-next should be better.

>
> Otherwise we need a Fixes: tag here and a better explanation in the
> commit message about what problem this fixes.  Are the netns's wrong
> sometimes without this conversion for example?
>
> Thanks.



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux