On Thu, 2019-08-01 at 06:50 -0400, Neil Horman wrote: > On Wed, Jul 31, 2019 at 03:23:46PM -0700, Joe Perches wrote: [] > You can say that if you want, but you made the point that your think the macro > as you have written is more readable. You example illustrates though that /* > fallthrough */ is a pretty common comment, and not prefixing it makes it look > like someone didn't add a comment that they meant to. The __ prefix is standard > practice for defining macros to attributes (212 instances of it by my count). I > don't mind rewriting the goto labels at all, but I think consistency is > valuable. Hey Neil. Perhaps you want to make this argument on the RFC patch thread that introduces the fallthrough pseudo-keyword. https://lore.kernel.org/patchwork/patch/1108577/
