RE: [PATCH] net/sctp: fix GCC8+ -Wpacked-not-aligned warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Qian Cai
> Sent: 26 July 2019 21:58
> 
> There are a lot of those warnings with GCC8+ 64bit,
> 
...
> Fix them by aligning the structures and fields to 8 bytes instead.
...
>  struct sctp_setpeerprim {
>  	sctp_assoc_t            sspp_assoc_id;
> -	struct sockaddr_storage sspp_addr;
> -} __attribute__((packed, aligned(4)));
> +	struct sockaddr_storage sspp_addr __attribute__((aligned(8)));
> +} __attribute__((packed, aligned(8)));

What happens to this one if you change both to aligned(4) ?
Much the same way as:
	struct {
		int a;
		long b __attribute__((aligned(4));
	};
is only 12 bytes on (most) 64bit systems.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)




[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux