On Wed, Jul 24, 2019 at 11:25:12AM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Jul 23, 2019 at 01:37:56AM +0800, Xin Long wrote: > > This patchset is to factor out some common code for > > sctp_sendmsg_new_asoc() and __sctp_connect() into 2 > > new functioins. > > > > Xin Long (4): > > sctp: check addr_size with sa_family_t size in > > __sctp_setsockopt_connectx > > sctp: clean up __sctp_connect > > sctp: factor out sctp_connect_new_asoc > > sctp: factor out sctp_connect_add_peer > > Nice cleanup! These patches LGTM. Hopefully for Neil as well. > > Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx> > Yes, agreed, this all looks good, but I would like to resolve the addr_length check issue before I ack it. Neil