From: Neil Horman <nhorman@xxxxxxxxxxxxx> Date: Wed, 12 Jun 2019 16:32:30 -0400 > On Wed, Jun 12, 2019 at 03:07:15PM -0300, Marcelo Ricardo Leitner wrote: >> On Tue, Jun 11, 2019 at 08:38:14PM -0400, Neil Horman wrote: >> > Based on comments from Xin, even after fixes for our recent syzbot >> > report of cookie memory leaks, its possible to get a resend of an INIT >> > chunk which would lead to us leaking cookie memory. >> > >> > To ensure that we don't leak cookie memory, free any previously >> > allocated cookie first. >> > >> > --- >> >> This marker can't be here, as it causes git to loose everything below. >> > thats intentional so that, when Dave commits it, the change notes arent carried > into the changelog (I.e. the change notes are useful for email review, but not > especially useful in the permanent commit history). 1) I like the changelog notes to be included 2) Your signoff etc. was in that area too so would have been lost as well