[PATCH lksctp-tools 3/9] peel_server: fix covscan warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



check the select and listen returned value, and initialize event.

Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx>
---
 src/apps/peel_server.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/apps/peel_server.c b/src/apps/peel_server.c
index 88545b4..24a1ef8 100644
--- a/src/apps/peel_server.c
+++ b/src/apps/peel_server.c
@@ -466,7 +466,8 @@ poll_fd(int fd)
 	printf("poll_fd\n");
 	FD_SET(fd,&readfds);
 
-	select(max,&readfds,&writefds,&exceptfds,NULL);
+	if (select(max, &readfds, &writefds, &exceptfds, NULL) == -1)
+		return(cameup);
 	if(FD_ISSET(fd,&readfds)){
 		printf("Read please\n");
 		cameup += my_sctpReadInput(fd,4100);
@@ -605,7 +606,7 @@ main(int argc, char **argv)
 	int i,fd;
 	uint16_t myport=0;
 	int magic=0;
-	struct sctp_event_subscribe event;
+	struct sctp_event_subscribe event = {0};
 	while((i= getopt(argc,argv,"m:M:")) != EOF){
 		switch(i){
 		case 'm':
@@ -639,7 +640,11 @@ main(int argc, char **argv)
 		return(-1);
 	}	
 	printf("fd uses port %d\n",ntohs(got.sin_port));
-	listen(fd,100);
+	if (listen(fd, 100) == -1) {
+		printf("listen err: %d\n", errno);
+		close(fd);
+		return(-1);
+	}
 	/* enable all event notifications */
 	event.sctp_data_io_event = 1;
 	event.sctp_association_event = 1;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux