On Wed, Jun 13, 2018 at 07:05:59PM -0700, David Miller wrote: > From: Neil Horman <nhorman@xxxxxxxxxxxxx> > Date: Wed, 13 Jun 2018 20:46:43 -0400 > > > Do you have any performance numbers to compare with and without this > > patch? Adding a function like this implies that any fixes that go > > into skb_gro_receive now need to be evaluated for this function too, > > which means theres an implied overhead in maintaining it. If we're > > signing up for that, I'd like to know that theres a significant > > performance benefit. > > Neil, I asked Xin and Marcelo to do this. > > There is no reason for GSO code to use a GRO helper. > > And this is, in particular, blocking some skb_gro_receive() surgery > I plan to perform. > I agree, I wasn't aware of your intentions regarding skb_gro_receive, and have acked the patch Neil -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
