Re: [PATCHv4 net-next 0/7] net: dst_confirm replacement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	Hello,

On Tue, 7 Feb 2017, David Miller wrote:

> From: Julian Anastasov <ja@xxxxxx>
> Date: Mon,  6 Feb 2017 23:14:10 +0200
> 
> > - I failed to understand the CXGB* code, I see dst_confirm()
> > calls but I'm not sure dst_neigh_output() was called. For now
> > I just removed the dst->pending_confirm flag and left all
> > dst_confirm() calls there. Any better idea?
> 
> As I said, it is trying to confirm neighbours based upon traffic
> occurring in the chips TCP offload stack.  The 'cm' in "iwch_cm.c"
> means "connection manager".
> 
> We can probably get to the neigh that will end up being used
> since there should be a flow key somewhere that we can use to
> determine the nexthop address for neigh lookup.

	I was reluctant to add slow neigh lookup there,
I was not sure if there is a saved address somewhere, for
the all places that call dst_confirm.

> > - Now may be old function neigh_output() should be restored
> > instead of dst_neigh_output?
> 
> Please elaborate.

	As dst_neigh_output does not use the dst arg anymore,
my idea was to rename dst_neigh_output to neigh_output, i.e.
just like it was before commit 5110effee8fd ("net: Do delayed neigh 
confirmation."

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux