From: Xin Long <lucien.xin@xxxxxxxxx> Date: Sun, 13 Nov 2016 21:44:37 +0800 > Now when users shutdown a sock with SEND_SHUTDOWN in sctp, even if > this sock has no connection (assoc), sk state would be changed to > SCTP_SS_CLOSING, which is not as we expect. > > Besides, after that if users try to listen on this sock, kernel > could even panic when it dereference sctp_sk(sk)->bind_hash in > sctp_inet_listen, as bind_hash is null when sock has no assoc. > > This patch is to move sk state change after checking sk assocs > is not empty, and also merge these two if() conditions and reduce > indent level. > > Fixes: d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received") > Reported-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > Tested-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx> Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html