Re: [PATCH net] sctp: fix SSN comparision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 16, 2016 at 01:33:47PM +0000, David Laight wrote:
> > > -static inline int ADDIP_SERIAL_gte(__u16 s, __u16 t)
> > > +static inline int ADDIP_SERIAL_gte(__u32 s, __u32 t)
> > >  {
> > >  	return ((s) == (t)) || (((t) - (s)) & ADDIP_SERIAL_SIGN_BIT);
> > >  }
> 
> Does gcc manage to compile that to (s32)((t) - (s)) <= 0 ?

I have no idea but I have a patch in the works for updating it to this
form, to be more like time_after(). Will probably post it by next week.

  Marcelo
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux