Now in the end of sctp_outq_flush, sctp calls sctp_packet_transmit in a loop. The return of current sctp_packet_transmit always covers the prior one's. If the last call of sctp_packet_transmit return a success, it may hide the error that returns from the prior call. This patch is to fix this by keeping the old error until the new error returns from sctp_packet_transmit. Did TAHI test against this fix, no regression is found. Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx> --- net/sctp/outqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c index 72e54a4..b97c8ad 100644 --- a/net/sctp/outqueue.c +++ b/net/sctp/outqueue.c @@ -1193,7 +1193,7 @@ sctp_flush_out: send_ready); packet = &t->packet; if (!sctp_packet_empty(packet)) - error = sctp_packet_transmit(packet, gfp); + error = sctp_packet_transmit(packet, gfp) ? : error; /* Clear the burst limited state, if any */ sctp_transport_burst_reset(t); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
