On Thu, May 26, 2016 at 4:21 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> On Thu, 2016-05-26 at 03:14 +0800, Xin Long wrote:
>> Now we cannot distinguish that one sk is a udp or sctp style when
>> we use ss to dump sctp_info. it's necessary to dump it as well.
>>
>> For sctp_diag, ss support is not officially available, thus there
>> are no official users of this yet, so we can add this field in the
>> middle of sctp_info without breaking user API.
>>
>> Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx>
>> ---
>> include/linux/sctp.h | 1 +
>> net/sctp/socket.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/include/linux/sctp.h b/include/linux/sctp.h
>> index dacb5e7..3a406af 100644
>> --- a/include/linux/sctp.h
>> +++ b/include/linux/sctp.h
>> @@ -761,6 +761,7 @@ struct sctp_info {
>> __u32 sctpi_s_autoclose;
>> __u32 sctpi_s_adaptation_ind;
>> __u32 sctpi_s_pd_point;
>> + __u32 sctpi_s_type;
>
> Well, this is also adding a 4-byte padding at the end of the structure.
>
>
> Basically, because of the 8-byte alignment cause by the __u64 fields,
> adding a single __u32 adds a padding.
>
> Don't you have another u32 info you'd like to publish ?
>
these days, I was trying to find an right u32 one for here, but no good
one, so I will put a __u32 __reserved3; there.
sctp still have some feature haven't yet been implemented, maybe
after that, we will find a good one. :)
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
