From: Xin Long <lucien.xin@xxxxxxxxx> Date: Thu, 14 Apr 2016 15:35:30 +0800 > sctp_diag will dump some important details of sctp's assoc or ep, we use > sctp_info to describe them, sctp_get_sctp_info to get them, and export > it to sctp_diag.ko. > > v2->v3: > - we will not use list_for_each_safe in sctp_get_sctp_info, cause > all the callers of it will use lock_sock. > > - fix the holes in struct sctp_info with __reserved* field. > because sctp_diag is a new feature, and sctp_info is just for now, > it may be changed in the future. > > Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx> Feedback was given here not to mix the changelog and the commit message. And I want to explicitly state that I totally and _COMPLETELY_ disagree with this. It is absolutely essential information and belongs in the commit message. Adding more information never hurts, so don't do this crap of putting things that might be useful to know after the "---", ever. Someone in the future might ask "why didn't he implement it like XXX" and the changelog can tell him that originally that is what was done and feedback was given to do it differently. So Xin thanks for correctly putting the changelog inside of the commit message, so that future developers can benefit from this knowledge. -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
