Re: [PATCH] Fix musl build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 11, 2016 at 03:09:50PM +0100, Yegor Yefremov wrote:
> On Fri, Mar 11, 2016 at 2:42 PM, Marcelo Ricardo Leitner
> <marcelo.leitner@xxxxxxxxx> wrote:
> > On Fri, Mar 11, 2016 at 10:20:47AM +0100, Yegor Yefremov wrote:
> >> Hi Marcelo,
> >>
> >> On Thu, Mar 10, 2016 at 6:31 PM,  <marcelo.leitner@xxxxxxxxx> wrote:
> >> > On Thu, Mar 10, 2016 at 09:54:26AM +0100, yegorslists@xxxxxxxxxxxxxx wrote:
> >> >> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> >> >>
> >> >> Replace __BEGIN_DECLS/__END_DECLS macros with following blocks:
> >> >>
> >> >> extern "C" {
> >> >>
> >> >> }
> >> >>
> >> >> __BEGIN_DECLS/__END_DECLS are not part of all C libraries.
> >> >>
> >> >> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> >> >
> >> > Applied, thanks Yegor.
> >>
> >> FYI: have tried to compile lksctp-tools with clang and found these warnings:
> >>
> >>   CC       bindx.lo
> >>   CC       connectx.lo
> >> ../../../src/lib/connectx.c:71:17: warning: comparison of unsigned
> >> expression < 0 is always false [-Wtautological-compare]
> >>         if (addrs_size < 0)
> >>             ~~~~~~~~~~ ^ ~
> >> ../../../src/lib/connectx.c:122:17: warning: comparison of unsigned
> >> expression < 0 is always false [-Wtautological-compare]
> >>         if (addrs_size < 0)
> >>             ~~~~~~~~~~ ^ ~
> >> ../../../src/lib/connectx.c:136:17: warning: comparison of unsigned
> >> expression < 0 is always false [-Wtautological-compare]
> >>         if (addrs_size < 0)
> >>             ~~~~~~~~~~ ^ ~
> >
> > I never tried using clang with lksctp-tools. Will put it in the ToDo
> > here, thanks.
> 
> Are you planning to make a release in the near future?
> 
> Gustavo and me have integrated lksctp-tools into
> https://buildroot.org/ and had to make some quirks like creating m4
> folder or removing test files, but now you have integrated those
> patches, so we can get rid of all those quirks.

Nice!

> This is not urgent and perhaps the package should stay for one-two
> weeks as it is, so that autobuilder can try some more configurations.

I'm targeting May but another release before that won't hurt if it helps
with the integration, we already have quite some commits applied since
last release, just let me know.

  Marcelo

--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux