On Sun, Mar 6, 2016 at 12:42 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > On sam., 2016-03-05 at 23:59 +0800, Xin Long wrote: > > Are you sure idr_alloc(... GFP_KERNEL) makes sense inside spin_lock_bh() > section ? > > idr_alloc() has : > > might_sleep_if(gfpflags_allow_blocking(gfp_mask)); > > A debug kernel (CONFIG_DEBUG_ATOMIC_SLEEP=y) should probably complain at > this point ? > OK, I got you, does it make sense to you if I just change GFP_NOWAIT to GFP_ATOMIC when sctp_assoc_set_id call idr_alloc_cyclic()? which also can avoid this call trace in my test. > > -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
