Re: [PATCH] libsctp: add pkg-config support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 29, 2016 at 12:25:42PM +0100, yegorslists@xxxxxxxxxxxxxx wrote:
> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> 
> pkg-config is a helper tool used when compiling applications and libraries.
> This patch adds automatic generation and installation of libsctp.pc file,
> that provides libsctp's version, compiler and linker information.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> ---
>  Makefile.am   |  5 +++++
>  configure.ac  |  3 ++-
>  libsctp.pc.in | 10 ++++++++++
>  3 files changed, 17 insertions(+), 1 deletion(-)
>  create mode 100644 libsctp.pc.in
> 
> diff --git a/Makefile.am b/Makefile.am
> index 2c9c8c6..58cacf0 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -9,6 +9,11 @@ EXTRA_DIST += ChangeLog AUTHORS COPYING COPYING.lib INSTALL \
>  	README ROADMAP NEWS \
>  	Makefile.vars Makefile.rules Makefile.dirs
>  
> +pkgconfigdir = $(libdir)/pkgconfig
> +pkgconfig_DATA = libsctp.pc
> +EXTRA_DIST += libsctp.pc.in
> +CLEANFILES = libsctp.pc

After applying this patch, I'm getting:

+ automake --foreign --add-missing --copy
configure.ac:31: installing 'bin/compile'
configure.ac:22: installing 'bin/missing'
Makefile.am:15: warning: CLEANFILES multiply defined in condition TRUE
...
Makefile.vars:7: ... 'CLEANFILES' previously defined here
Makefile.am:1:   'Makefile.vars' included from here
src/apps/Makefile.am: installing 'bin/depcomp'

lksctp-tools]$ grep -w CLEANFILES Makefile.vars Makefile.am 
Makefile.vars:CLEANFILES = 
Makefile.am:CLEANFILES = libsctp.pc

I checked some other projects and seems that setting it to clean this
file is not a standard practice, specially with CLEANFILES because it
will clean this file with 'make clean' while it's being generated by
configure and not the make step. If you find it really necessary, it
would be better to use DISTCLEANFILES instead.

Thanks,
Marcelo

> +
>  # bin or src products may be required to generate stuff in test/
>  SUBDIRS = man bin src doc
>  
> diff --git a/configure.ac b/configure.ac
> index 778dac5..675fb96 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -72,5 +72,6 @@ AC_CONFIG_FILES([lksctp-tools.spec
>  		src/lib/Makefile
>  		src/testlib/Makefile
>  		src/withsctp/Makefile
> -		doc/Makefile])
> +		doc/Makefile
> +		libsctp.pc])
>  AC_OUTPUT
> diff --git a/libsctp.pc.in b/libsctp.pc.in
> new file mode 100644
> index 0000000..b1eafaf
> --- /dev/null
> +++ b/libsctp.pc.in
> @@ -0,0 +1,10 @@
> +prefix=@prefix@
> +exec_prefix=@exec_prefix@
> +libdir=@libdir@
> +includedir=@includedir@
> +
> +Name: sctp
> +Description: User-level SCTP API library
> +Version: @VERSION@
> +Libs: -L${libdir} -lsctp
> +Cflags: -I${includedir}
> -- 
> 2.7.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux