On Thu, Nov 12, 2015 at 01:07:07PM +0800, Xin Long wrote: > now sctp auth cannot work well when setting a hmacid manually, which > is caused by that we didn't use the network order for hmacid, so fix > it by adding the transformation in sctp_auth_ep_set_hmacs. > > even we set hmacid with the network order in userspace, it still > can't work, because of this condition in sctp_auth_ep_set_hmacs(): > > if (id > SCTP_AUTH_HMAC_ID_MAX) > return -EOPNOTSUPP; > > so this wasn't working before and thus it won't break compatibility. > > Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx> > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx> > --- > net/sctp/auth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/auth.c b/net/sctp/auth.c > index 4f15b7d..1543e39 100644 > --- a/net/sctp/auth.c > +++ b/net/sctp/auth.c > @@ -809,8 +809,8 @@ int sctp_auth_ep_set_hmacs(struct sctp_endpoint *ep, > if (!has_sha1) > return -EINVAL; > > - memcpy(ep->auth_hmacs_list->hmac_ids, &hmacs->shmac_idents[0], > - hmacs->shmac_num_idents * sizeof(__u16)); > + for (i = 0; i < hmacs->shmac_num_idents; i++) > + ep->auth_hmacs_list->hmac_ids[i] = htons(hmacs->shmac_idents[i]); > ep->auth_hmacs_list->param_hdr.length = htons(sizeof(sctp_paramhdr_t) + > hmacs->shmac_num_idents * sizeof(__u16)); > return 0; > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
