RE: [PATCH v2 net-next 1/3] net: sctp: Open out the check for Nagle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Vlad Yasevich
...
> > +	if (inflight != 0)
> > +		/* Nothing unacked */
> > +		return SCTP_XMIT_OK;
> 
> This doesn't look right.  First, the comment doesn't match the condition.
> Second, when we have stuff in-flight we might be affected be Nagle.  Thus,
> I think the condition should be:
>        if (!inflight)
> 
> Then the commend and logic holds.

Gah, I accidentally inverted the condition :-(
I changed it to a an explicit comparison because 'inflight' is actually
the number of bytes that are unacked.

I'll repost the series later in the week.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux