On Sat, Mar 01, 2014 at 12:30:09AM +0100, Daniel Borkmann wrote:
> On 03/01/2014 12:15 AM, Dan Carpenter wrote:
> >Hello Daniel Borkmann,
> >
> >This is a semi-automatic email about new static checker warnings.
> >
> >The patch 4c47af4d5eb2: "net: sctp: rework multihoming retransmission
> >path selection to rfc4960" from Feb 20, 2014, leads to the following
> >Smatch complaint:
> >
> >net/sctp/associola.c:1322 sctp_assoc_update_retran_path()
> > warn: variable dereferenced before check 'trans_next' (see line 1319)
> >
> >net/sctp/associola.c
> > 1305 /* Iterate from retran_path's successor back to retran_path. */
> > 1306 for (trans = list_next_entry(trans, transports); 1;
> > 1307 trans = list_next_entry(trans, transports)) {
> > 1308 /* Manually skip the head element. */
> > 1309 if (&trans->transports == &asoc->peer.transport_addr_list)
> > 1310 continue;
> > 1311 if (trans->state == SCTP_UNCONFIRMED)
> > 1312 continue;
> > 1313 trans_next = sctp_trans_elect_best(trans, trans_next);
> > 1314 /* Active is good enough for immediate return. */
> > 1315 if (trans_next->state == SCTP_ACTIVE)
> > ^^^^^^^^^^^^^^^^^
> >Dereference.
>
> That is a false-positive.
>
> trans_next at that time is being assigned through sctp_trans_elect_best() a
> guaranteed non-NULL pointer.
>
Can you remove the NULL check then?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
