On Tue, Jan 21, 2014 at 03:44:05PM +0800, Wang Weidong wrote:
> In sctp.h we can find some macro locking wrappers. As Neil point out that:
>
> "Its because in the origional implementation of the sctp protocol, there was a
> user space test harness which built the kernel module for userspace execution to
> cary our some unit testing on the code. It did so by redefining some of those
> locking macros to user space friendly code. IIRC we haven't use those unit
> tests in years, and so should be removing them, not adding them to other
> locations."
>
> So I remove them.
>
> Wang Weidong (7):
> sctp: remove macro sctp_spin_[un]lock_irqrestore
> sctp: remove macro sctp_local_bh_{disable|enable}
> sctp: remove macro sctp_spin_[un]lock
> sctp: remove macros sctp_write_[un]_lock
> sctp: remove macros sctp_read_[un]lock
> sctp: remove macros sctp_{lock|release}_sock
> sctp: remove macros sctp_bh_[un]lock_sock
>
> include/net/sctp/sctp.h | 27 ++-----------
> net/sctp/endpointola.c | 4 +-
> net/sctp/input.c | 54 +++++++++++++-------------
> net/sctp/proc.c | 12 +++---
> net/sctp/protocol.c | 4 +-
> net/sctp/sm_sideeffect.c | 16 ++++----
> net/sctp/socket.c | 98 ++++++++++++++++++++++++------------------------
> 7 files changed, 98 insertions(+), 117 deletions(-)
>
> --
> 1.7.12
>
>
>
I would have preferred that this all be done as one patch, so that if anyone was
still using this macro set they would have a single change to bisect to, but
given that we already had several non-macrotized uses of these locks, its not
overly relevant
Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
