Ok I'll repost when I get out of class tomorrow evening Neil On Dec 9, 2013 8:32 PM, David Miller <davem@xxxxxxxxxxxxx> wrote: > > From: Neil Horman <nhorman@xxxxxxxxxxxxx> > Date: Fri, 6 Dec 2013 10:29:15 -0500 > > > @@ -2205,6 +2206,12 @@ static int sctp_setsockopt_autoclose(struct sock *sk, char __user *optval, > > if (copy_from_user(&sp->autoclose, optval, optlen)) > > return -EFAULT; > > > > + if (sp->autoclose > net->sctp.max_autoclose) { > > + pr_warn("Capping autoclose value %d to defined maximum of %lu\n", > > + sp->autoclose, net->sctp.max_autoclose); > > + sp->autoclose = net->sctp.max_autoclose; > > + } > > Please don't add this warning. > > If we already do this for certain setsockopt calls in SCTP, that just > means we have bugs to fix. > ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f