On 12/03/2013 07:30 AM, Wang Weidong wrote:
As Michael pointed out that when max_burst is 0, it just disable max_burst. It declared in rfc6458#section-8.1.24. so add the check in sctp_transport_burst_limited, when it 0, just do nothing. Suggested-by: Vlad Yasevich <vyasevich@xxxxxxxxx> Suggested-by: Michael Tuexen <Michael.Tuexen@xxxxxxxxxxxxxxxxx> Signed-off-by: Wang Weidong <wangweidong1@xxxxxxxxxx> --- net/sctp/transport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sctp/transport.c b/net/sctp/transport.c index e332efb..e580e34 100644 --- a/net/sctp/transport.c +++ b/net/sctp/transport.c @@ -573,7 +573,8 @@ void sctp_transport_burst_limited(struct sctp_transport *t) u32 old_cwnd = t->cwnd; u32 max_burst_bytes; - if (t->burst_limited) + /* if the max_burst is 0, do notihing */ + if (t->burst_limited || !asoc->max_burst) return;
Minor nitpick ... you can remove the comment as it contains a typo and basically says what the code is doing anyway, so you could instead make the code a bit more clear for readers e.g. "asoc->max_burst == 0".
max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu);
-- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
