On 10/28/2013 10:44 AM, Julian Anastasov wrote: [...]
Sorry, just now noticed the errors from scripts/checkpatch.pl: ERROR: do not use assignment in if condition #78: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:103: + if (!(ret = ip_vs_app_pkt_out(cp, skb))) ERROR: do not use assignment in if condition #120: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:149: + if (!(ret = ip_vs_app_pkt_in(cp, skb))) total: 2 errors, 0 warnings, 81 lines checked I know that you copied the TCP logic that was added by me but now we should split the complex conditions at both places: ret = ... if (!ret) return 0; Otherwise patch looks good and I'll ack v3 with the above changes.
Ok, sure, I'll update with the cosmetic change. -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
