On Mon, Jul 01, 2013 at 06:33:57PM +0200, Daniel Borkmann wrote: > On 07/01/2013 01:33 PM, Neil Horman wrote: > >On Mon, Jul 01, 2013 at 11:31:36AM +0200, Daniel Borkmann wrote: > >>After having reworked the debugging framework, Neil and Vlad agreed to > >>get rid of the leftover SCTP_DBG_TSNS code for a couple of reasons: > >> > >>We can use systemtap scripts to investigate these things, we now have > >>pr_debug() helpers that make life easier, and if we really need anything > >>else besides those tools, we will be forced to come up with something > >>better than we have there. Therefore, get rid of this ifdef debugging > >>code entirely for now. > >> > >>Signed-off-by: Daniel Borkmann <dborkman@xxxxxxxxxx> > >>CC: Vlad Yasevich <vyasevich@xxxxxxxxx> > >>CC: Neil Horman <nhorman@xxxxxxxxxxxxx> > >>--- > >> On top of [PATCH net-next v4 0/2] Rework SCTP debugging framework. > >> > >I think you mean on top of v4 2/2, but regardless: > > > >Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx> > > > >I don't suppose you want to write a stap script to drop in the sourceware > >examples area, in case anyone comes looking for this functionality again? :) > > I could put this into my longer-term todo queue, sure, sounds like a plan. > Sounds reasonable. If I get time I'll let you know and take a poke at it myself. Thanks Neil > >Thanks > >Neil > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html