Re: [PATCH v2] sctp: Add buffer utilization fields to /proc/net/sctp/assocs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Dilip Daya <dilip.daya@xxxxxx>
Date: Thu, 11 Apr 2013 15:49:56 -0400

> From: Dilip Daya <dilip.daya@xxxxxx>
> 
> sctp: Add buffer utilization fields to /proc/net/sctp/assocs
> 
> This patch adds the following fields to /proc/net/sctp/assocs output:
> 
> 	- sk->sk_wmem_alloc    (transmit queue bytes committed)
> 	- sk->sk_wmem_queued   (persistent queue size)
> 	- sk->sk_sndbuf        (size of send buffer in bytes)
> 	- sk->sk_rcvbuf        (size of receive buffer in bytes)

Please use smaller field names, perhaps "wmema wmemq sndbuf rcvbuf"

> Patch applies to v3.8.6 and v3.9-rc6.

This does not belong in the commit message proper, it belongs in the
ancillary information you provide after the "---" delimeter.

> v2: Not changing spacing between the fields.

Similarly this supplemental information belongs after "---"

> +		seq_printf(seq, "\t%8lu %5d %5d %4d %4d %4d %8d "
> +						"%8d %8d %8d %8d",

This is not indented properly, the second line should have the "
appearing at the first column after the openning parenthesis
of the seq_printf() call.

The goal is not to exclusively use TAB characters to indent the
line into outer space, the goal is to use the appropriate of
TAB, then space, characters as necessary to indent the code to
the correct column.
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux