Re: [PATCH v2] net/sctp: Validate parameter size for SCTP_GET_ASSOC_STATS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Vlad Yasevich <vyasevich@xxxxxxxxx>
Date: Wed, 27 Feb 2013 16:00:42 -0500

> On 02/27/2013 03:57 PM, Guenter Roeck wrote:
>> Building sctp may fail with:
>>
>> In function ʽcopy_from_userʼ,
>>      inlined from ʽsctp_getsockopt_assoc_statsʼ at
>>      net/sctp/socket.c:5656:20:
>> arch/x86/include/asm/uaccess_32.h:211:26: error: call to
>>      ʽcopy_from_user_overflowʼ declared with attribute error:
>>      copy_from_user()
>>      buffer size is not provably correct
>>
>> if built with W=1 due to a missing parameter size validation
>> before the call to copy_from_user.
>>
>> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>> ---
>> v2: Fix by moving the existing parameter size validation up
>>      in the function instead of adding an additional one.
> 
> This works too...
> 
> Acked-by: Vlad Yasevich <vyasevich@xxxxxxxxx>

I'll apply this and queue it up for -stable, thanks everyone.
?τθΊ{.nΗ+?·???­?+%?Λ?±ιέΆ??w?Ί{.nΗ+?·??{±ώΗ-§ψ§Ά?ʽά¨}©?²Ζ zΪ&j:+v?¨ώψ―ω?w?ώ?ΰ2?ή?¨θ­Ϊ&ʼ)ίʽ«aΆΪ??ϋΰzΏδzΉή?ϊ+?ω???έʼj??wθώf



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux