Re: [PATCH v2] sctp: Change defaults on cookie hmac selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 01/07/13 16:48, Vlad Yasevich a écrit :
No, thats the problem, your old config is no longer valid with this new Kconfig
file. Your config is telling the config utility that you want your default Cookie hmac to be MD5, but you've explicitly told it (via your yes "" | make oldconfig command), that you want SCTP_COOKIE_HMAC_MD5 to be disabled, so the config utility is left with no choice to prompt you again for a default hmac, which your command answers again by saying SCTP_DEFAULT_COOKIE_HMAC_MD5 (the default choice of 1). Thats your loop, you keep telling the config utility that you both want the default hmac to be md5, and that you don't want to allow md5
to be an available hmac alg.

Thats not a bug. I'm sorry if your old configuration needs manual updating, but there are no guarantees that old configurations will 'just work' in perpituity.


Neil

Actually, I think we have a bug in the config. Look at the thermal driver config again. It has:

choice
        prompt "Default Thermal governor"
        default THERMAL_DEFAULT_GOV_STEP_WISE

config THERMAL_DEFAULT_GOV_STEP_WISE
    ...
config THERMAL_DEFAULT_GOV_FAIR_SHARE
    ...
config THERMAL_DEFAULT_GOV_USER_SPACE
    ...
endchoice


SCTP has:

choice
        prompt "Default SCTP cookie HMAC encoding"
        default SCTP_COOKIE_HMAC_MD5

config SCTP_DEFAULT_COOKIE_HMAC_MD5
    ...
config SCTP_DEFAULT_COOKIE_HMAC_SHA1
    ...
config SCTP_DEFAULT_COOKIE_HMAC_NONE
    ...
endchoice

See the difference?  The default value of the choice statement needs to
be one of the available choices.

Right, since none of the config symbols actually exist when migrating from and oldconfig we are still being prompted, which is just fine actually. Having the config symbol being the default a member of the choice/endchoice section is what should be expected.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux