On Thu, Nov 15, 2012 at 04:01:20PM +0100, Michele Baldessari wrote: > The current SCTP stack is lacking a mechanism to have per association > statistics. This is an implementation modeled after OpenSolaris' > SCTP_GET_ASSOC_STATS. > > Userspace part will follow on lksctp if/when there is a general ACK on > this. > > V2) > - Implement partial retrieval of stat struct to cope for future expansion > - Kill the rtxpackets counter as it cannot be precise anyway > - Rename outseqtsns to outofseqtsns to make it clearer that these are out > of sequence unexpected TSNs > - Move asoc->ipackets++ under a lock to avoid potential miscounts > - Fold asoc->opackets++ into the already existing asoc check > - Kill unneeded (q->asoc) test when increasing rtxchunks > - Do not count octrlchunks if sending failed (SCTP_XMIT_OK != 0) > - Don't count SHUTDOWNs as SACKs > - Move SCTP_GET_ASSOC_STATS to the private space API > - Adjust the len check in sctp_getsockopt_assoc_stats() to allow for > future struct growth > - Move association statistics in their own struct > - Update idupchunks when we send a SACK with dup TSNs > - return min_rto in max_rto when RTO has not changed. Also return the > transport when max_rto last changed. > > Signed-off: Michele Baldessari <michele@xxxxxxxxxx> > Acked-by: Thomas Graf <tgraf@xxxxxxx> Yes, I think this is good, I still don't like the idea of having to do these via an ioctl, but I suppose it fits well enough. Neil Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
