From: Neil Horman <nhorman@xxxxxxxxxxxxx> Date: Mon, 29 Oct 2012 14:32:13 -0400 > Lots of points in the sctp_cmd_interpreter function treat the sctp_cmd_t arg as > a void pointer, even though they are written as various other types. Theres no > need for this as doing so just leads to possible type-punning issues that could > cause crashes, and if we remain type-consistent we can actually just remove the > void * member of the union entirely. > > Change Notes: > > v2) > * Dropped chunk that modified SCTP_NULL to create a marker pattern > should anyone try to use a SCTP_NULL() assigned sctp_arg_t, Assigning > to .zero provides the same effect and should be faster, per Vlad Y. > > v3) > * Reverted part of V2, opting to use memset instead of .zero, so that > the entire union is initalized thus avoiding the i164 speculative load > problems previously encountered, per Dave M.. Also rewrote > SCTP_[NO]FORCE so as to use common infrastructure a little more > > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
