On Fri, Oct 26, 2012 at 03:12:54PM -0400, Vlad Yasevich wrote: > On 10/26/2012 09:41 AM, Neil Horman wrote: > >Lots of points in the sctp_cmd_interpreter function treat the sctp_cmd_t arg as > >a void pointer, even though they are written as various other types. Theres no > >need for this as doing so just leads to possible type-punning issues that could > >cause crashes, and if we remain type-consistent we can actually just remove the > >void * member of the union entirely. > > > >Change Notes: > > > >v2) > > * Dropped chunk that modified SCTP_NULL to create a marker pattern > > should anyone try to use a SCTP_NULL() assigned sctp_arg_t, Assigning > > to .zero provides the same effect and should be faster, per Vlad Y. > > > >Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx > >CC: Vlad Yasevich <vyasevich@xxxxxxxxx> > > Acked-by: Vlad Yasevich <vyasevich@xxxxxxxxx> > > -vlad > Thanks for the ACk Vlad, do you have any thoughts regarding Dave M's comments above on this .zero/memset question? He makes a good point regarding complete initalization I think. Neil -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
