Jan Ariyasu <jan.ariyasu@xxxxxxxxx> writes: > The following set of patches enable network-namespaces for the SCTP protocol. > > The multitude of global parameters are stored in a net_generic > structure, and the bulk of the patches enable the protocol to access > the parameters on a per-namespace basis. The first five patches > enable netns handling of the protocol, procfs and sysfs. I am going to do something to muddy the waters here, that I had hoped to avoid when I saw your patchset. A few weeks ago I wanted to play with sctp and also made a network namespace enabled version. I am not deeply attached to my changes, however when comparing the differences I realized that your code fails to make the lookup of associations per network namespace. Given that we only have source and destination port to lookup assoications by this almost guarantees one network namespace can accidentially use the association of another network namespace meerly by reusing the same ports. The downside with my version is that it does not make all of the sctp tunables per network namespace the way yours does, but making all of the tunables per network namespace should be straight forward from my base. My patchset also misses some nice to haves like making the association id allocation per network namespace. It is not important for correctness of the code but it might allow an information leak between namespaces. So Jan I am going to send my patchset and hopefully you can rebase your changes to make all of the tunables per network namespace on top of mine. Since my patchset is half the size of your I think that is the most reasonable way to go. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
