On 7/24/12, Vlad Yasevich <vyasevich@xxxxxxxxx> wrote: >>>> And I should clarify the above judgment code. >>>> AFAIK, there should be two cases for the bundling when invalid >>stream >>>> identifier error happens: >>>> 1). COOKIE_ACK ERROR SACK >>>> 2). ERROR SACK >>>> So I need to deal with the two cases differently. >>>> >>>> >>> Sorry but I just don't buy that the above are the only 2 cases. What >>if there are addip chunks as well? What if there are some other >>extensions also. This code has to be generic enough to handle any >>condition. >>> >>Aha, you are right, this may happens. >>So I think the general solution is to fix this problem in the enqueue >>side. >>What do you think? any better suggestion! >> > > Don't have code in front of me but what if we carry the error condition to > where we queue the Sack and add the error side effect then? Yes, this is the most direct way to fix this problem. But I don't think it's the best way since we will take care of a lot of things and it also involves in lots of changes to side effect processing. I prefer to Neil Horman's way for the solution since only COOKIE_ACK chunk is allowed to place ahead of SACK chunk when bundling into one packet. What do you think? Thanks, Xufeng Zhang > > -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
