On Sat, Jul 21, 2012 at 02:45:03AM -0400, Vlad Yasevich wrote: > Neil Horman <nhorman@xxxxxxxxxxxxx> wrote: ><snip> > >+ > >+ val.spt_pathmaxrxt = trans->pathmaxrxt; > >+ val.spt_pathpfthld = trans->pf_retrans; > >+ } > >+ > >+ if (copy_to_user(optval, &val, optlen)) > >+ return -EFAULT; > >+ > >+ return optlen; > > I don't think you can simply return this. You have to call put_user() with the value to write it back to the User. See how other get calls are done. > > -Vlad > Yeah, sorry, I had assumed that the put_user for the return code was part of the common sctp_getsockopt path and didn't go check. Thanks, I'll respin this later tonight. Neil -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
