On Dec 15, 2011, at 4:07 PM, Vlad Yasevich wrote: > I think it would be better to keep this value in seconds and get rid > of division in the setsockopt code. We could then have a min and max > values where max value could be something like 2 days. I really don't > see an autoclose value that is bigger then that being very useful. In > fact, most of the time these values are very small as one wants to close > out idle associations. Now I start to think exposing a new sysctl option might be a little overkill since autoclose is often small. How about this? 1) Simply store autoclose in seconds in setsockopt. 2) Avoid overflow in associola.c. asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE] = (sp->autoclose > MAX_SCHEDULE_TIMEOUT / HZ) ? MAX_SCHEDULE_TIMEOUT : (unsigned long)sp->autoclose * HZ; Or we could use INT_MAX instead of MAX_SCHEDULE_TIMEOUT if you want to keep that value consistent across 32/64 bits. - xi -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
