Max Matveev wrote, at 06/21/2011 09:29 AM:
> On Mon, 20 Jun 2011 17:41:07 +0800, Shan Wei wrote:
>
> shanwei> Max Matveev wrote, at 06/20/2011 04:36 PM:
> >> On Mon, 20 Jun 2011 16:29:25 +0800, Shan Wei wrote:
> >>
> >> + Default: 1 page
>
> shanwei> how about 4K?
>
> Not everybody uses 4K pages. I can change it to 4K but it will be
> (technically) incorrect.
Use "1 Page" is more exact.
Other parameters(tcp_rmem, tcp_rmem, udp_rmem_min) directly
use magic number(4K or 4096).
So also need same change.
>
> >>
> >> sctp_wmem - vector of 3 INTEGERs: min, default, max
> >> - See tcp_wmem for a description.
> >> + Only the first value ("min") is used, "default" and "max" are
> >> + ignored and may be removed in the future versions.
>
> shanwei> sctp_wmem parameter include all three fields never be used
> shanwei> by sctp protocol. The min value is not used.
>
> I was trying to avoid the embarrassment of admitting that there is a
> tunable which does nothing. Should I add another patch to remove
> the tunable?
No.
Currently, sctp protocol does't implement tunable memory management.
Just provide an interface to user, but no function.
What we need is to implement it, not remove the interface simply.
>
> max
>
--
Best Regards
-----
Shan Wei
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
