From: Joe Perches <joe@xxxxxxxxxxx> Date: Thu, 12 May 2011 12:19:09 -0700 > This variable only needs initialization when cmsgs.info > is NULL. > > Don't use memset, just initialize every struct member. > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> I don't think you do this, this structure has padding holes on pretty much every architecture. It starts with 3 u16's, then there is a u32, so there is a 2-byte piece of padding after the 3rd u16. Can you prove that these uninitialized portions never make it to userspace? If you can, that proof belongs in the commit message. I think it's too risky. -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
