> Wei, while you are re-spinning this patch set I want to bring up > something I just noticed in the SCTP code. > > The ->dst_saddr() method is not used by anything, it appears. > > The ipv4 variant, sctp_v4_dst_saddr() is called internally by the > ipv4 specific code, but that's it. > > So I think the ->dst_saddr member of sctp_pf can be completely > removed, as can sctp_v6_dst_saddr(). > > The sctp_v4_dst_saddr() function, of course, will need to be retained. David, thanks to noticed this. I will cleanup it. And I have a stupid question about the rule of backport. Since those patchs have existed so long time, when I backport those patchs, I'd better fix the bug in the original patch, or create new patch to fix it? Also how about some thing need to improvement like the ->dst_saddr() method? -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
