Re: [PATCH net-next-2.6 4/7] sctp: remove useless arguments from get_saddr() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Miller <davem@xxxxxxxxxxxxx>
Date: Tue, 26 Apr 2011 00:12:27 -0700 (PDT)

> I really get grumpy when I have to fix up stuff like this:
> 
> net/sctp/ipv6.c: In function ʽsctp_v6_get_saddrʼ:
> net/sctp/ipv6.c:382: warning: unused variable ʽdaddrʼ

Now I'm even more grumpy, if I only apply the first 3 patches:

net/sctp/ipv6.c: In function ʽsctp_v6_dst_lookupʼ:
net/sctp/ipv6.c:259: warning: assignment makes integer from pointer without a cast

it goes away later but you're not testing the intermediate steps
of your SCTP patch backports and as a result you are going to
break bisecting.

I'm reverting this patch series, fix this up and actually test
the intermediate builds and functionality before resubmission.

?τθΊ{.nΗ+?·???­?+%?Λ?±ιέΆ??w?Ί{.nΗ+?·??{±ώΗ-§ψ§Ά?ʽά¨}©?²Ζ zΪ&j:+v?¨ώψ―ω?w?ώ?ΰ2?ή?¨θ­Ϊ&ʼ)ίʽ«aΆΪ??ϋΰzΏδzΉή?ϊ+?ω???έʼj??wθώf



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux