From: Holger Hans Peter Freyther <zecke@xxxxxxxxxxx> The store to ret is not needed. In case it is 0 the method will be exited directly, if not ret will be assigned again and then returned to the caller. Signed-off-by: Holger Hans Peter Freyther <zecke@xxxxxxxxxxx> Acked-by: Wei Yongjun <yjwei@xxxxxxxxxxxxxx> --- net/sctp/socket.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index b2bed35..5f72996 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -393,9 +393,8 @@ SCTP_STATIC int sctp_do_bind(struct sock *sk, union sctp_addr *addr, int len) * detection. */ addr->v4.sin_port = htons(snum); - if ((ret = sctp_get_port_local(sk, addr))) { + if (sctp_get_port_local(sk, addr)) return -EADDRINUSE; - } /* Refresh ephemeral port. */ if (!bp->port) -- 1.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html