> On Thu, 2010-11-11 at 20:06 -0500, Dan Rosenberg wrote: > > diff --git a/net/can/bcm.c b/net/can/bcm.c > > index 08ffe9e..5960ad7 100644 > > --- a/net/can/bcm.c > > +++ b/net/can/bcm.c > [...] > > + seq_printf(m, ">>> socket %lu", sock_i_ino(sk)); > > Why decimal here... > > [...] > > + /* unique socket inode as filename */ > > + sprintf(bo->procname, "%lx", sock_i_ino(sk)); > > ...and hexadecimal here? > > Ben. > You're right, it should be consistent. I avoided decimal in the /proc filename because it may be too long - the next version will do the same for the seq_print output. -Dan -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
