On Thu, Nov 11, 2010 at 08:24:09PM -0500, Dan Rosenberg wrote: > > If we really have to do this. At least don't duplicate all this code. Do > > the check in the printf argument: > > > > seq_printf(seq, "%4d: %08X:%04X %08X:%04X" > > ... > > capable(CAP_NET_ADMIN) ? sp : 0, > > > > I would even move the decision whether to expose kernel addresses or not > > to a function so we can change behavior in one place. > > I wrote it this way because the format specifier must also be changed, > or the %p output will print "(null)", which cannot be parsed by > userspace programs expecting "(nil)" or 0. I could include another > check inside the format specifier, but that seemed pretty ugly. But > then again, it's ugly either way. Considering the amount of duplication you are about to do, you may want to think about adding a new pointer format extension then. We already have special '%p' modes for IPv6 addresse, MAC addresses and various other pointer types. It wouldn't be hard to add one which does not print (null). -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
