Shan Wei wrote:
> Just like T4-RTO, T3-RXT timeout events, add HEARTBEAT timeout
> counter for debug. It is useful because all these timeout events
> cause association error counter to increase.
>
Unlinke T4-RTO and T3-RTO, heartbeat timeouts happen all the time
and do not necessarily mean that a something is wrong.
This mib item is not going to provide any useful information since it's
going to wrap around way too fast, especially since use has the control
to set the HB interval extremely low, thus generating a ton of timeouts.
It may be worth tracking the number of non-responded heartbeats, since those
will actually cause association destruction.
-vlad
>
> Signed-off-by: Shan Wei <shanwei@xxxxxxxxxxxxxx>
> ---
> include/net/sctp/sctp.h | 1 +
> net/sctp/proc.c | 1 +
> net/sctp/sm_statefuns.c | 2 ++
> 3 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
> index 65946bc..f7fb5de 100644
> --- a/include/net/sctp/sctp.h
> +++ b/include/net/sctp/sctp.h
> @@ -263,6 +263,7 @@ enum {
> SCTP_MIB_IN_PKT_BACKLOG,
> SCTP_MIB_IN_PKT_DISCARDS,
> SCTP_MIB_IN_DATA_CHUNK_DISCARDS,
> + SCTP_MIB_HEARTBEAT_EXPIREDS,
> __SCTP_MIB_MAX
> };
>
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 5584d1a..53263ca 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -74,6 +74,7 @@ static const struct snmp_mib sctp_snmp_list[] = {
> SNMP_MIB_ITEM("SctpInPktDiscards", SCTP_MIB_IN_PKT_DISCARDS),
> SNMP_MIB_ITEM("SctpInDataChunkDiscards", SCTP_MIB_IN_DATA_CHUNK_DISCARDS),
> SNMP_MIB_ITEM("SctpT1Retransmits", SCTP_MIB_T1_RETRANSMITS),
> + SNMP_MIB_ITEM("SctpHeartbeatExpireds", SCTP_MIB_HEARTBEAT_EXPIREDS),
> SNMP_MIB_SENTINEL
> };
>
> diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
> index 24b2cd5..8d3e223 100644
> --- a/net/sctp/sm_statefuns.c
> +++ b/net/sctp/sm_statefuns.c
> @@ -974,6 +974,8 @@ sctp_disposition_t sctp_sf_sendbeat_8_3(const struct sctp_endpoint *ep,
> {
> struct sctp_transport *transport = (struct sctp_transport *) arg;
>
> + SCTP_INC_STATS(SCTP_MIB_HEARTBEAT_EXPIREDS);
> +
> if (asoc->overall_error_count >= asoc->max_retrans) {
> sctp_add_cmd_sf(commands, SCTP_CMD_SET_SK_ERR,
> SCTP_ERROR(ETIMEDOUT));
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
