Re: [PATCH 3/3] sctp: check invalid value of length parameter in error cause

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




RFC4960, section 3.3.7 said:
  If an endpoint receives an ABORT with a format error or no TCB is
  found, it MUST silently discard it.

When an endpoint receives ABORT that parameter value is invalid,
drop it.

Signed-off-by: Shan Wei<shanwei@xxxxxxxxxxxxxx>
---
  net/sctp/sm_statefuns.c |    9 ++++++++-
  1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index 32e75ea..0d2e62f 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -2423,8 +2423,15 @@ static sctp_disposition_t __sctp_sf_do_9_1_abort(const struct sctp_endpoint *ep,

  	/* See if we have an error cause code in the chunk.  */
  	len = ntohs(chunk->chunk_hdr->length);
-	if (len>= sizeof(struct sctp_chunkhdr) + sizeof(struct sctp_errhdr))
+	if (len>= sizeof(struct sctp_chunkhdr) + sizeof(struct sctp_errhdr)) {
+
+		sctp_errhdr_t *err;
+		sctp_walk_errors(err, chunk->chunk_hdr);
+		if ((void *)err != (void *)chunk->chunk_hdr + len)

As Vlad said, use "if ((void*)err != (void*)chunk->chunk_end)" instead.

+			return sctp_sf_pdiscard(ep, asoc, type, arg, commands);
+
  		error = ((sctp_errhdr_t *)chunk->skb->data)->cause;
+	}

  	sctp_add_cmd_sf(commands, SCTP_CMD_SET_SK_ERR, SCTP_ERROR(ECONNRESET));
  	/* ASSOC_FAILED will DELETE_TCB. */

--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux