Re: [PATCH] sctp: IPsec rules are ineffective with ipv6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Nicolas Dichtel wrote:
> What about this one?
> 
> Only compilation tested.
> 
> xfrm_lookup() is missing in IPv6 output path. Call it when dst is build.
> Initial patch was written by Junwei Zhang <junwei.zhang@xxxxxxxxx>
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>

Looks like it might do the right thing.  Please run your tests
on this an let me.

Thanks
-vlad

> 
> Le 28.01.2010 16:24, Vlad Yasevich a écrit :
>>
>> David Miller wrote:
>>> From: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxxxxxx>
>>> Date: Wed, 27 Jan 2010 15:12:59 +0100
>>>
>>>> xfrm_lookup() is missing in sctp_v6_xmit(), add it.
>>>>
>>>> Signed-off-by: Junwei Zhang <junwei.zhang@xxxxxxxxx>
>>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
>>> Doing this every transmit packet is overkill.
>>>
>>> Whatever calculates the route that ends up in skb_dst(skb)
>>> should be making this xfrm_lookup() call, not here.
>>>
>>
>>
>> Hmm.. Interesting.  Looks like ip_route_output_key() will
>> do xfrm_lookup for you, but there is no ipv6 route lookup call
>> that will do the same thing.
>>
>> I guess we'll need to add an xfrm_lookup call in sctp_v6_get_dst().
>>
>> -vlad


--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux