Andrei Pelinescu-Onciul wrote: > When setting the autoclose timeout in jiffies there is a possible > integer overflow if the value in seconds is very large > (e.g. for 2^22 s with HZ=1024). The problem appears even on > 64-bit due to the integer promotion rules. The fix is just a cast > to unsigned long. > > Signed-off-by: Andrei Pelinescu-Onciul <andrei@xxxxxxxxx> > --- > net/sctp/associola.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index 525864b..7f69f4d 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -166,7 +166,7 @@ static struct sctp_association *sctp_association_init(struct sctp_association *a > asoc->timeouts[SCTP_EVENT_TIMEOUT_HEARTBEAT] = 0; > asoc->timeouts[SCTP_EVENT_TIMEOUT_SACK] = asoc->sackdelay; > asoc->timeouts[SCTP_EVENT_TIMEOUT_AUTOCLOSE] = > - sp->autoclose * HZ; > + (unsigned long)sp->autoclose * HZ; > > /* Initilizes the timers */ > for (i = SCTP_EVENT_TIMEOUT_NONE; i < SCTP_NUM_TIMEOUT_TYPES; ++i) This becomes unnecessary with Patch 3. -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
