On Mon, Jul 06, 2009 at 01:45:48PM +0800, Wei Yongjun wrote: > Commit 'net: Move rx skb_orphan call to where needed' broken sctp protocol > with warning at inet_sock_destruct(). Actually, sctp can do this right with > sctp_sock_rfree_frag() and sctp_skb_set_owner_r_frag() pair. > > sctp_sock_rfree_frag(skb); > sctp_skb_set_owner_r_frag(skb, newsk); > > This patch not revert the commit d55d87fdff8252d0e2f7c28c2d443aee17e9d70f, > instead remove the sctp_sock_rfree_frag() function. It took me a while to understand your patch but yeah it does seem to be the right fix. So essentially we were freeing the packet twice as my newly added skb_orphan in sctp_skb_set_owner_r is repeating what sctp_sock_rfree_frag has already done for the migration case. While your patch simply eliminates sctp_sock_rfree_frag so that we only free things once. > Signed-off-by: Wei Yongjun <yjwei@xxxxxxxxxxxxxx> Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
