Wei Yongjun wrote: > This patch fix to check the unrecognized ASCONF parameter before > access it. > > Signed-off-by: Wei Yongjun <yjwei@xxxxxxxxxxxxxx> > --- > net/sctp/sm_make_chunk.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c > index 61cc607..ab91712 100644 > --- a/net/sctp/sm_make_chunk.c > +++ b/net/sctp/sm_make_chunk.c > @@ -2861,6 +2861,11 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc, > addr_param = (union sctp_addr_param *) > ((void *)asconf_param + sizeof(sctp_addip_param_t)); > > + if (asconf_param->param_hdr.type != SCTP_PARAM_ADD_IP && > + asconf_param->param_hdr.type != SCTP_PARAM_DEL_IP && > + asconf_param->param_hdr.type != SCTP_PARAM_SET_PRIMARY) > + return SCTP_ERROR_UNKNOWN_PARAM; > + > switch (addr_param->v4.param_hdr.type) { > case SCTP_PARAM_IPV6_ADDRESS: > if (!asoc->peer.ipv6_address) Clean up the 'default' case, since it now becomes dead code. -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html