Vlad Yasevich wrote:
> Eugene Teo wrote:
>> Vlad Yasevich wrote:
[...]
>>> + if (authkey->sca_keylength > optlen) {
>>> + ret = -EINVAL;
>>> + goto out;
>> Is there a better upper bound check?
>
> Hm... optlen - sizeof(struct sctp_authkey) is more accurate.
>
> There is really no other bound.
Linus suggested that it is better to declare an upper bound for key_len.
I think it makes a lot of sense as a key shouldn't be as long as the
boundary limit of its declared data type.
Thanks,
Eugene
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
